Skip to content

update to Opentelemetry v0.31.x#7

Open
fbielejec wants to merge 9 commits into
will-bank:mainfrom
fbielejec:main
Open

update to Opentelemetry v0.31.x#7
fbielejec wants to merge 9 commits into
will-bank:mainfrom
fbielejec:main

Conversation

@fbielejec

@fbielejec fbielejec commented Dec 22, 2025

Copy link
Copy Markdown

Objective

Update the crate to use more recent version of opentelemetry rust libs

Proposed changes

  • Removed build_layer which seems to not be in use (?)
  • various changes to make the code compile while keeping the logic intact

Note

Upgrade to Rust 2024 and OpenTelemetry 0.31, refactor tracing to use SdkTracerProvider with updated formatter and shutdown, and bump related dependencies.

  • Tracing/Telemetry:
    • Replace build_tracer with build_tracer_provider returning SdkTracerProvider; wire tracing_opentelemetry::layer() with provider.tracer("DataDogTelemetry").
    • Change TracerShutdown to own SdkTracerProvider and consume self on shutdown(); remove global shutdown re-export.
    • Set Datadog propagator via global::set_text_map_propagator.
  • Formatter:
    • Update lookup_trace_info to use OtelData::{trace_id, span_id} APIs; minor write/error handling tweaks.
  • Dependencies/Tooling:
    • Bump opentelemetry, opentelemetry_sdk, opentelemetry-http to ^0.31.0; tracing-opentelemetry to ^0.32.0; axum-tracing-opentelemetry to 0.30; opentelemetry-datadog to 0.19.0; reqwest to 0.12.
    • Set crate edition to 2024; add rust-toolchain.toml; configure rustfmt for 2024.

Written by Cursor Bugbot for commit bec0aa9. Configure here.

@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

1 similar comment
@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

3 similar comments
@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

1 similar comment
@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

3 similar comments
@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@fbielejec fbielejec marked this pull request as draft December 22, 2025 13:05
@fbielejec fbielejec marked this pull request as ready for review December 22, 2025 13:28
@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

1 similar comment
@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

3 similar comments
@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

1 similar comment
@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

1 similar comment
@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

1 similar comment
@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

Make OpenTelemetry-related dependencies optional behind a `datadog`
feature (enabled by default) so lightweight consumers can depend on
just tracing-subscriber without compiling the OTel stack.
@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

1 similar comment
@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

3 similar comments
@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

CLI tools need stdout reserved for program output (e.g. --output-json).
Logs should go to stderr to avoid mixing with structured output.
Add `init_with_target(OutputTarget)` to allow callers to choose
stdout or stderr for log output. `init()` defaults to stdout
for backwards compatibility.
@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

1 similar comment
@willbank-platforms

Copy link
Copy Markdown

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

3 similar comments
@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

@willbank-platforms

Copy link
Copy Markdown
Error parsing command: EOF found when expecting closing quote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants