Skip to content

Conversation

soul2zimate
Copy link
Contributor

Issue: https://issues.redhat.com/browse/WFCORE-6246 Upgrade snakeyaml from 1.33 to 2.0

cc @ehsavoie @jamezp

@github-actions github-actions bot added the deps-changed Dependencies have been checked, and there are changes highlighted in a comment label Feb 27, 2023
@github-actions
Copy link

Dependency Tree Analyzer Output:

Major Version Changes:

  • org.yaml:snakeyaml:jar:1.33:compile -> 2.0

CC @wildfly/prod

@soul2zimate
Copy link
Contributor Author

soul2zimate commented Feb 27, 2023

SnakeYaml 2.0 contains Backwards-incompatible changes , see https://bitbucket.org/snakeyaml/snakeyaml/wiki/Changes.

microprofile and microprofile-tck integration tests use snakeyaml 1.33 via

[INFO] +- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.13.4:compile
[INFO] |  \- org.yaml:snakeyaml:jar:1.33:compile

It seems that we need to wait and upgrade jackson-dataformats-text 2.15 (tentative goal of getting the first Release Candidate out by March 2023.) in WFLY to incorporate FasterXML/jackson-dataformats-text#390

EDIT: Test passed since WFLY has been upgraded jackson to 2.14. contains this commit FasterXML/jackson-dataformats-text@9f822fb

@soul2zimate soul2zimate marked this pull request as draft February 27, 2023 04:19
@xstefank
Copy link
Member

/retest

@xstefank
Copy link
Member

@soul2zimate /retest won't work on draft PRs, so I just opened a new PR to test with latest wildfly/main again since I can't reproduce the failure locally. Please unmark this PR as draft :)

@bstansberry
Copy link
Contributor

@jamezp @pferraro FYI.

@soul2zimate soul2zimate closed this Mar 1, 2023
@soul2zimate soul2zimate reopened this Mar 1, 2023
@soul2zimate soul2zimate marked this pull request as ready for review March 1, 2023 07:22
@wildfly wildfly deleted a comment from wildfly-ci Mar 1, 2023
@wildfly wildfly deleted a comment from wildfly-ci Mar 1, 2023
@wildfly wildfly deleted a comment from wildfly-ci Mar 1, 2023
@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Mar 3, 2023
@yersan yersan merged commit e0ed3dd into wildfly:main Mar 3, 2023
@soul2zimate soul2zimate deleted the WFCORE-6246-main branch March 6, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-changed Dependencies have been checked, and there are changes highlighted in a comment ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants