Use logfile; fix DaemonSet example #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syslog is not generally available inside a container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syslog is not generally available inside a container, so use Logfile to write to the expected logfile directly.
I tried using stdout instead, but it didn't work -- no logs in
kubectl logsor in Stackdriver. I think this is becauserun-agent.shis the container's entrypoint, not thecollectddaemon.The good news is run-agent.sh tails
/var/log/collectd.log, so as-is we do see logs in kubectl logs and in Stackdriver.This also makes a whitespace-only, documentation-only change that causes the example DaemonSet to break :).
(See also gpii-ops#1 though I will delete that fork soon.)