[flake8] solve some flake8 issues

Change-Id: Icf7ae49daa4d8ff874de419abdf07535d9b6174e

pywikibot/page/_user.py

@@ -1,6 +1,6 @@
 """Object representing a Wiki user."""
 #
-# (C) Pywikibot team, 2009-2022
+# (C) Pywikibot team, 2009-2024
 #
 # Distributed under the terms of the MIT license.
 #
@@ -261,10 +261,8 @@ def send_email(self, subject: str, text: str, ccme: bool = False) -> bool:
         mailrequest = self.site.simple_request(**params)
         maildata = mailrequest.submit()
 
-        if 'emailuser' in maildata \
-           and maildata['emailuser']['result'] == 'Success':
-            return True
-        return False
+        return ('emailuser' in maildata
+                and maildata['emailuser']['result'] == 'Success')
 
     def block(self, *args, **kwargs):
         """

pywikibot/site/_apisite.py

@@ -1,6 +1,6 @@
 """Objects representing API interface to MediaWiki site."""
 #
-# (C) Pywikibot team, 2008-2023
+# (C) Pywikibot team, 2008-2024
 #
 # Distributed under the terms of the MIT license.
 #
@@ -1280,7 +1280,7 @@ def has_data_repository(self) -> bool:
     def image_repository(self) -> BaseSite | None:
         """Return Site object for image repository e.g. commons."""
         code, fam = self.shared_image_repository()
-        if bool(code or fam):
+        if code or fam:
             return pywikibot.Site(code, fam, self.username())
 
         return None

pywikibot/site/_siteinfo.py

@@ -1,6 +1,6 @@
 """Objects representing site info data contents."""
 #
-# (C) Pywikibot team, 2008-2023
+# (C) Pywikibot team, 2008-2024
 #
 # Distributed under the terms of the MIT license.
 #
@@ -82,7 +82,7 @@ def _post_process(prop, data) -> None:
             if prop in ('namespaces', 'magicwords'):
                 for index, value in enumerate(data):
                     # namespaces uses a dict, while magicwords uses a list
-                    key = index if type(data) is list else value
+                    key = index if isinstance(data, list) else value
                     for p in Siteinfo.BOOLEAN_PROPS[prop]:
                         data[key][p] = p in data[key]
             else:

scripts/maintenance/unidata.py

@@ -10,7 +10,7 @@
 .. versionadded:: 8.4
 """
 #
-# (C) Pywikibot team, 2018-2023
+# (C) Pywikibot team, 2018-2024
 #
 # Distributed under the terms of the MIT license.
 #
@@ -38,7 +38,7 @@ def chars_uppers_wikilinks():
     chars = []
     uppers = []
     wikilinks = ''
-    for i in range(0, maxunicode + 1):
+    for i in range(maxunicode + 1):
         c = chr(i)
         uc = c.upper()
         if uc != c:

setup.py

@@ -24,6 +24,8 @@
 #
 # Distributed under the terms of the MIT license.
 #
+from __future__ import annotations
+
 import os
 import re
 import sys
@@ -57,6 +59,8 @@
         'flake8-bugbear>=23.3.12',
         'flake8-comprehensions>=3.13.0',
         'flake8-docstrings>=1.4.0',
+        'flake8-executable',
+        'flake8-future-annotations',
         'flake8-mock-x2',
         'flake8-print>=5.0.0',
         'flake8-quotes>=3.3.2',

tests/utils.py

@@ -390,7 +390,7 @@ def version(self):
     def image_repository(self):
         """Return Site object for image repository e.g. commons."""
         code, fam = self.shared_image_repository()
-        if bool(code or fam):
+        if code or fam:
             return pywikibot.Site(code, fam, self.username(),
                                   interface=self.__class__)
         return None
@@ -411,7 +411,7 @@ def data_repository(self):
                             'wikivoyage'):
             code, fam = None, None
 
-        if bool(code or fam):
+        if code or fam:
             return pywikibot.Site(code, fam, self.username(),
                                   interface=DryDataSite)
         return None