New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with Snackbar action after completing SE Feed items. #5205

Merged

cooltey merged 1 commit into main from seFeedCardLaunch

Jan 6, 2025

Member

dbrant commented Jan 6, 2025

This fixes issues (and a potential crash) when tapping the View action in the snackbar after completing a Suggested Edit from the Feed card.

The fragment from which the snackbar is launched is no longer attached (replaced by a new Suggestion), so we cannot use the same context for launching an activity.
In the case of Image Tags, the WikiSite for launching the View action was being constructed incorrectly.

Phabricator:
https://phabricator.wikimedia.org/T383084


          Fix issues with Snackbar action after completing SE Feed items.

8c70dd2

dbrant added Minor High Priority labels

dbrant requested review from cooltey and Williamrai as code owners

January 6, 2025 21:30

cooltey merged commit 687975f into main

2 checks passed

cooltey deleted the seFeedCardLaunch branch

January 6, 2025 22:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority Minor