Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple tracking #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Apple tracking #11

wants to merge 1 commit into from

Conversation

rockretep
Copy link
Collaborator

Enables apple tracking by simply printing out when an avatar eats an apple, and includes a script for parsing STDOUT and collecting the results into a csv file. Updated the configuration for two substrates to support it, but substrate configurations can easily be updated to include it. Not the best solution for apple tracking, but it does work. Unfortunately it might slow down evaluations due to the print spam.

… apple, and includes a script for parsing STDOUT and collecting the results into a csv file. Added the Not the best solution for apple tracking, but it does work. Unfortunately it might slow down evaluations due to the print spam.
@SrGonao
Copy link
Collaborator

SrGonao commented May 28, 2024

Oh. But this is just the reward. I thought that we were going to track if the fields are depleted

@SoyGema
Copy link
Collaborator

SoyGema commented May 29, 2024

No. Peter was doing apple tracking from the start . We discuss it a few weeks ago and the goal was that , but Im not sure if you had another agreement.

@SoyGema SoyGema self-assigned this May 29, 2024
Copy link
Collaborator

@SoyGema SoyGema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SrGonao
Copy link
Collaborator

SrGonao commented May 30, 2024

As I had told you and written in the document, apple tracking is /exactly/ the same as tracking reward. The only case where apple tracking makes sense is if you are tracking the amount of apples alive (not the amount of apples consumed). If feels weird that after having pointed this out multiple times the plan did not change, specially given the troubles implementing it.
Also in your messages you mention the "apple-calypse", which this does not measure.
I think at this point this should /not/ be merged, as it slows down evaluations and does not add any new information, unless someone can explain what I'm missing here.

@SoyGema
Copy link
Collaborator

SoyGema commented May 30, 2024

Many things are said and I guess people implement and do at the best of their abilities.

When this task was made some metrics were defined under a meeting you where not part of that based on apple tracking would define some things .

@SoyGema
Copy link
Collaborator

SoyGema commented May 30, 2024

@rockretep don't erase or close. We will definetly decouple apple gathering from reward in future iterations for safety study concerns so this is useful even if this slows down evals a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants