Fixes/jruby ruby head #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etagwerker
force-pushed
the
fixes/jruby-ruby-head
branch
from
ae51afa to
700a4dc
Compare
faisal
reviewed
Mar 7, 2025
rubycritic.gemspec
Outdated
| @@ -46,6 +51,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency 'bundler', '>= 2.0.0' | |||
| if RUBY_PLATFORM == 'java' | |||
| spec.add_development_dependency 'pry-debugger-jruby' | |||
| spec.add_development_dependency 'jar-dependencies', '~> 0.4.1' | |||
There was a problem hiding this comment.
Given the comment about jar-dependencies in https://www.jruby.org/2025/02/11/jruby-9-4-12-0.html, "jar-dependencies upgraded to 0.5.4 to fix an issue parsing Maven output on Java versions 9 and higher," should we lock jar-dependencies to -> 0.5.4, or even remove the version restriction so as to pick up whatever jruby wants to install?
|
This seems worth taking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I'd like to mark the
ruby-headjob as "green" even if it fails. It's adding unnecessary noise when it's red.Check list: