Skip to content

remove init for namespace packaging #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rbavery
Copy link
Member

@rbavery rbavery commented Jan 31, 2025

the presence of init.py files breaks installing wherobots-inference in the wherobots namespace if wherobots-inference doesn't have an init.py in the wherobots namespace. All subpackages in the namespace shouldn't have init.pys in order to be installed as standalone packages or be installed in the namespace.

@paleolimbot and I made this same change to wherobots-inference and wherobots-tools and are testing in wbc-images.

https://github.com/wherobots/wbc-images/pull/566

notion task:
https://www.notion.so/wherobots/namespace-packaging-is-broken-for-wherobots-inference-18bba32ec0278084a6a8fa99b9b8316a

tested this and the package can still be installed and imported after poetry install

# rave at rave-desktop in ~/work/wherobots-python-dbapi on git:ryan/remove-init-namespace-packaging ● [12:25:39]
→ poetry run python                         
Python 3.11.9 | packaged by conda-forge | (main, Apr 19 2024, 18:36:13) [GCC 12.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from wherobots.db import connect

>>> from wherobots.db.region import Region
>>> from wherobots.db.runtime import Runtime

@rbavery
Copy link
Member Author

rbavery commented Feb 1, 2025

closing in favor of #28

@rbavery rbavery closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants