remove init for namespace packaging #26
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the presence of init.py files breaks installing wherobots-inference in the wherobots namespace if wherobots-inference doesn't have an init.py in the wherobots namespace. All subpackages in the namespace shouldn't have init.pys in order to be installed as standalone packages or be installed in the namespace.
@paleolimbot and I made this same change to wherobots-inference and wherobots-tools and are testing in wbc-images.
https://github.com/wherobots/wbc-images/pull/566
notion task:
https://www.notion.so/wherobots/namespace-packaging-is-broken-for-wherobots-inference-18bba32ec0278084a6a8fa99b9b8316a
tested this and the package can still be installed and imported after
poetry install