[WIP] Add variant support #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
commented
Jul 22, 2025
| else str(artifact_path) | ||
| ) | ||
| else: | ||
| command = ['python', '-u', '-m', 'hatchling', 'build', '--target', target] |
Author
There was a problem hiding this comment.
For testing, you may want to replace python with /workspace/.venv/bin/python, to use the updated version of Hatchling.
mgorny
reviewed
Jul 22, 2025
mgorny
left a comment
mgorny
left a comment
There was a problem hiding this comment.
Also you probably need a PEP517 config_settings interface too. It is quite common to build hatchling packages via python -m build.
Author
|
Continued in pypa#2037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.