Skip to content

python3 support added#5

Open
Lasith-Niro wants to merge 1 commit intowheelerda:masterfrom
Lasith-Niro:master
Open

python3 support added#5
Lasith-Niro wants to merge 1 commit intowheelerda:masterfrom
Lasith-Niro:master

Conversation

@Lasith-Niro
Copy link

@Lasith-Niro Lasith-Niro commented Jul 21, 2018

I added python 3 support for .mbz extractor.

Copy link

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% ruff check --select=F821 extract-mbz3.py also finds 6 other undefined names.
https://docs.astral.sh/ruff/rules/undefined-name


make_fn = lambda i: os.path.join(path, '%s(%d)%s' % (name, i, ext))

for i in xrange(2, sys.maxint):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xrange() was removed in Python 3.

def make_slugified_filename(filename):
path, name = os.path.split(filename)
name, ext = os.path.splitext(filename)
return os.path.join(path, "%s%s" % (slugify(unicode(name)), ext))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unicode() was removed in Python 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants