-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add darkmode styles #429
Add darkmode styles #429
Conversation
This is exciting!
Thank you especially for this attention to detail; keeping some of our individuality is very nice!
Please feel free to remove!
Ideally we would move these to HTML's I am a bit confused by the implications of the structure you have here for documents beyond the normal standards. Notably:
|
Cool.
Makes sense, I can do so.
To be fair, I was a bit confused too. It's not clear to me what subset of CSS files are used by any particular sort of document using this repo. We should probably document this in a README. It looks like:
Inverting that mapping, we have:
This organization isn't workable for what we want to do here. There is no file shared by all four categories, but I need colors to be shared across all of them. How about we add a In total, then, we'd have:
Sound reasonable? Related, y'all vendor some of the Bikeshed styles, but not all of them. Do you have a general policy you'd like to set up, which we can capture in some documentation? Or is it best to leave it somewhat ad hoc, and you're okay with Bikeshed inlining some of its styles? |
I just looked at a review draft and nm, all that the proposed (Maybe call it |
Hm, do we want to consolidate the HTML and HTML-dev stylesheets into this repo as well? It would make future changes easier if they weren't spread across multiple repos. |
The intent is that review drafts not support any niceties, so I don't think we need any new files. You can just locate everything common in the shared file, I think keeping HTML's CSS files in HTML is probably for the best, as more often we edit HTML's CSS files to do something HTML-specific, and coordinating that across two repositories is not great. |
…ors, and put Henri in the correct sorted position.
… as well. Move the Wattsi dfn-panel styles to HTML's personal stylesheet.
Okay, PR up to date!
Now I've checked these styles against HTML, HTML dev, DOM, and DOM RD. I think that's all the categories of things WHATWG produces? |
Ping on final approval for this. A few other PRs need to be merged in concert: |
Having to remember this is really error-prone...
(Part 1 of the work for whatwg/meta#222)
I manually checked the appearance of these styles against DOM, compat, webidl, and HTML itself. As far as I can tell, everything is handled well.
This'll need an accompanying PR for whatwg's boilerplate, I'll put that up momentarily.