Make dummyURL from the basic URL parser with a special scheme #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@annevk Not sure if this kind of simple change address the issue. Could you give some advice? Thank you! |
annevk
reviewed
Mar 24, 2025
…orrect basic URL parser invocation
annevk
reviewed
Mar 25, 2025
|
Updated based on your suggestions, thank you! |
annevk
reviewed
Mar 25, 2025
spec.bs
Outdated
| </div> | ||
|
|
||
| <div algorithm> | ||
| To <dfn>canonicalize a username</dfn> given a string |value|: | ||
|
|
||
| 1. If |value| is the empty string, return |value|. | ||
| 1. Let |dummyURL| be a new [=URL record=]. | ||
| 1. Let |dummyURL| be the result of [=create a dummy URL=]. |
There was a problem hiding this comment.
You want "creating" not "create" here (and below) to get a proper sentence (you don't have to change the <dfn> for that, as I mentioned Bikeshed takes care of making that work).
annevk
approved these changes
Mar 25, 2025
|
@sisidovski when merging this, please take care to follow https://github.com/whatwg/meta/blob/main/COMMITTING.md (in particular the Squash and merge section). I noticed this went wrong a few times for this repository. Feel free to reach out on https://whatwg.org/chat if you have questions or ask @domenic internally. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #252.
We should not use URL records directly to canonicalize components, we should specify a special scheme as a default scheme. When we create a dummy URL, it should be created from the basic URL parser. This is not ideal but this can be achieved by creating a dummy URL with this fixed URL string.
Preview | Diff