Editorial: Add proper serialization of URL properties#224
Merged
jeremyroman merged 4 commits intowhatwg:mainfrom Apr 19, 2024
Merged
Editorial: Add proper serialization of URL properties#224jeremyroman merged 4 commits intowhatwg:mainfrom
jeremyroman merged 4 commits intowhatwg:mainfrom
Conversation
Collaborator
|
Thanks for the pull request. Only a couple things before I can merge it.
|
Contributor
Author
|
@jeremyroman I updated my PR title and submitted a participant agreement, waiting for its validation. |
Collaborator
|
The WHATWG page says:
@annevk do you know what need to be done for it to be "verified"? I'm not super familiar with how individual participation works. |
Member
Collaborator
|
Gotcha; done. (Was that linked from the check status page? If so, I missed it.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix missing serialization steps of internal port and host properties in the spec. The URL parser return port as an integer and host as either a hostname string, an integer (IPv4 address) or an array of integers (IPv6 address). For further processing by the URLPattern code these properties need to be properly converted to string.
The issue was discussed here: #202 (comment)
Preview | Diff