Add experimental support to build using Bikeshed #296
+1,255
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
commented
Feb 20, 2025
src/main.rs
Outdated
| // Find the paths we need. | ||
| let cache_dir = path_from_env("HTML_CACHE", ".cache"); | ||
| let source_dir = path_from_env("HTML_SOURCE", "../html"); | ||
| let use_bikeshed_str = env::var_os("USE_BIKESHED"); |
There was a problem hiding this comment.
It'd probably be less messy to use a --bikeshed command line arg.
foolip
commented
Feb 20, 2025
This was referenced Mar 12, 2025
This ends up quite noisy in the output and can probably be minified somehow. It does link more things together however.
|
Although this is far from complete, I'd like to add the experimental mode to html-build to make collaboration on it easier. At TPAC I'd like to demo how to use it (which is a lot easier if this is merged) and where people can help out if they're interested. I'm happy to clean up some things if requested, I wrote this as an experiment and probably left a few weird things in that need explaining or removing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.