[WebDriver BiDi] emulated network offline #1852
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
added a commit
to w3c/webdriver-bidi
that referenced
this pull request
Oct 7, 2025
First step addressing #776. * Fail all the intercepted requests, WebSocket and WebTransport. * Html spec: whatwg/html#11575 * Fetch spec: whatwg/fetch#1852
6 tasks
noamr
reviewed
Oct 8, 2025
fetch.bs
Outdated
| <li><p>Let <var>isEmulatedOffline</var> be the result of <a>WebDriver BiDi network is offline</a> | ||
| with <var>request</var>'s <a for=request>client</a>. | ||
|
|
||
| <li><p>If <var>isEmulatedOffline</var> is true, then return a <a>network error</a>. |
There was a problem hiding this comment.
I don't think you need the variable, you can condense it to return a network error if the check returned true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If WebDriver BiDi emulated network offline condition, fail any outgoing fetch.
emulation.setNetworkConditions:offlineweb-platform-tests/wpt#55300emulation.setNetworkConditions:offlineGoogleChromeLabs/chromium-bidi#3819(See WHATWG Working Mode: Changes for more details.)
Preview | Diff