-
Notifications
You must be signed in to change notification settings - Fork 356
Add WebDriver BiDi network request logging #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jgraham
wants to merge
1
commit into
whatwg:main
Choose a base branch
from
jgraham:webdriver_request_logging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2157,6 +2157,11 @@ Unless stated otherwise, it is false. | |
|
||
<p class=note>This is for exclusive use by HTML's navigate algorithm. [[!HTML]] | ||
|
||
<p>A <a for=/>request</a> has an associated <dfn export for=request>WebDriver navigation id</dfn> | ||
(null or a string). Unless stated otherwise, it is null. | ||
|
||
<p class=note>This is for exclusive use by HTML's navigate algorithm. [[!HTML]] | ||
|
||
<p>A <a for=/>request</a> has an associated boolean <dfn export for=request>render-blocking</dfn>. | ||
Unless stated otherwise, it is false. | ||
|
||
|
@@ -2198,6 +2203,15 @@ otherwise, it is unset. | |
<a for=request>done flag</a>, and <a for=request>timing allow failed flag</a> are used as | ||
bookkeeping details by the <a for=/>fetch</a> algorithm. | ||
|
||
<p>A <a for=/>request</a> has an associated | ||
<dfn export for=request id=concept-webdriver-id>WebDriver id</dfn> | ||
which is a unique string automatically set when the <a for=/>request</a> is created. | ||
|
||
<p class=note>The [=request/WebDriver id=] is used by WebDriver-BiDi. It remains constant | ||
across all requests resulting from a redirect of an initial request. When a | ||
request is [=request/cloned=], the created request gets a unique | ||
[=request/WebDriver id=]. [[!WEBDRIVER-BIDI]] | ||
|
||
<hr> | ||
|
||
<p>A <dfn export>subresource request</dfn> is a <a for=/>request</a> | ||
|
@@ -2274,7 +2288,9 @@ is to return the result of <a>serializing a request origin</a> with <var>request | |
|
||
<ol> | ||
<li><p>Let <var>newRequest</var> be a copy of <var>request</var>, except for its | ||
<a for=request>body</a>. | ||
<a for=request>body</a> and <a for=request>WebDriver id</a>. | ||
|
||
<li><p>Set <var>newRequest</var>'s <a for=request>WebDriver id</a> to a new unique string. | ||
|
||
<li><p>If <var>request</var>'s <a for=request>body</a> is non-null, set <var>newRequest</var>'s | ||
<a for=request>body</a> to the result of <a lt=clone for=body>cloning</a> <var>request</var>'s | ||
|
@@ -4824,6 +4840,11 @@ steps: | |
<a for=request>URL</a>, <var>fetchParams</var>'s <a for="fetch params">request</a>'s | ||
<a for=request>initiator type</a>, <var>global</var>, <var>cacheState</var>, | ||
<var>bodyInfo</var>, and <var>responseStatus</var>. | ||
|
||
<li><p>If <var>response</var> is a <a>network error</a>, run | ||
the <a>WebDriver BiDi fetch error</a> steps with <var>request</var>. Otherwise | ||
run the <a>WebDriver BiDi response completed</a> steps with | ||
<var>request</var> and <var>response</var>. | ||
</ol> | ||
|
||
<li> | ||
|
@@ -5165,6 +5186,13 @@ these steps: | |
<a>filtered response</a>; otherwise to <var>response</var>'s | ||
<a for="filtered response">internal response</a>. | ||
|
||
<li><p>Run the [=WebDriver BiDi response started=] steps with | ||
<var>request</var> and <var>response</var>. | ||
<!-- Service Workers is responsible for emmitting the WebDriver BiDi | ||
request events in this case. That's necessary to ensure that the events are | ||
only generated if the service worker will handle the fetch, and to get the | ||
correct event ordering in the case of network fallback --> | ||
jgraham marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
<li> | ||
<p>If one of the following is true | ||
|
||
|
@@ -5292,8 +5320,12 @@ these steps: | |
|
||
<dt>"<code>follow</code>" | ||
<dd> | ||
<ol><li><p>Set <var>response</var> to the result of running <a>HTTP-redirect fetch</a> given | ||
<var>fetchParams</var> and <var>response</var>.</ol> | ||
<ol> | ||
<li>Run the <a>WebDriver BiDi response completed</a> steps with <var>request</var> and | ||
<var>response</var>. | ||
<li><p>Set <var>response</var> to the result of running <a>HTTP-redirect fetch</a> given | ||
<var>fetchParams</var> and <var>response</var>. | ||
</ol> | ||
</dl> | ||
<!-- not resetting internalResponse since it's no longer used anyway --> | ||
</ol> | ||
|
@@ -5699,6 +5731,10 @@ run these steps: | |
<p class=note>This intentionally does not depend on <var>httpRequest</var>'s | ||
<a for=request>credentials mode</a>. | ||
|
||
<!-- After this point the request is not further modified before being either | ||
retrieved from the cache or sent --> | ||
<li><p>Run the <a>WebDriver BiDi before request sent</a> steps with <var>request</var>. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jgraham does it intentionally use |
||
|
||
<li><p>Set <var>httpCache</var> to the result of <a>determining the HTTP cache partition</a>, | ||
given <var>httpRequest</var>. | ||
|
||
|
@@ -5794,6 +5830,8 @@ run these steps: | |
<li><p><a>If aborted</a>, then return the <a for=/>appropriate network error</a> for | ||
<var>fetchParams</var>. | ||
|
||
<li><p>If <var>response</var> is not null, run the <a>WebDriver BiDi response | ||
started</a> steps with <var>request</var> and <var>response</var>. | ||
|
||
<!-- If response is still null, we require a forwarded request. --> | ||
<li> | ||
|
@@ -6057,6 +6095,9 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps: | |
|
||
<li><p>Wait until all the HTTP response headers are transmitted. | ||
|
||
<li><p>Run the [=WebDriver BiDi response started=] steps with | ||
|request| and |response|. | ||
|
||
<li><p>Let <var>status</var> be the HTTP response's status code. | ||
|
||
<li> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.