Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage slot manipulation centrally and special case replace operations #695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Manage slot manipulation centrally and special case replace operations #695

wants to merge 1 commit into from

Commits on Jan 19, 2021

  1. Manage slot manipulation centrally and special case replace operations 

    This is an attempt at fixing WICG/webcomponents#764.

I first wrote an algorithm that combined the operations done by remove and insert. I then used that for replace and replace all. I then abstracted it to avoid duplication.

I'm a little worried that this is not correct as this delays assigning slotables to a slot quite a bit, which I think might be observable in some cases.
    @annevk
    annevk committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    68e57ef View commit details
    Browse the repository at this point in the history