Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare properties for PHP 8.2+ compatibility and fix missing semicolon #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Declare properties for PHP 8.2+ compatibility and fix missing semicolon #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6a80e3
Declare properties
samcleathero Nov 14, 2024
1fe88f8
Fix missing semicolon
samcleathero Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Helper/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ class Config extends AbstractHelper
{
const PREFIX = 'what3words/';
const SCOPE_TYPE_STORE = 'store';

private $productMetadata;
private $storeManager;

/**
* Config constructor.
* @param Context $context
Expand Down
2 changes: 1 addition & 1 deletion Model/Config/Comment/SaveCoordinates.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ class SaveCoordinates implements CommentInterface
{
public function getCommentText($elementValue)
{
return "<strong>NOTE:</strong> This feature won't work if you're on a free plan or have exceeded your quota. Check the console and network panel for errors. No coordinates will be saved. Please review our <a href=\"https://accounts.what3words.com/select-plan\">plans</a> for higher allowances."
return "<strong>NOTE:</strong> This feature won't work if you're on a free plan or have exceeded your quota. Check the console and network panel for errors. No coordinates will be saved. Please review our <a href=\"https://accounts.what3words.com/select-plan\">plans</a> for higher allowances.";
}
}