Skip to content

Add missing action bar to rich-skill-form-component #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ottonomy wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add missing action bar to rich-skill-form-component #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8ea887
Add missing action bar to rich-skill-form-component
ottonomy Apr 27, 2023
4e56cd1
fixup: Remove unused icon
ottonomy Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion ui/src/app/richskill/form/rich-skill-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,30 @@ <h3 class="t-visuallyHidden" id="save-quicklinks">Quick Links</h3>

</div>

<div class="l-stickyBar-x-bar t-hidden-desktopMin t-padding-medium t-padding-top">
<div class="l-stickyBar-x-bar t-hidden-desktopMin">
<!-- @actionbarhorizontal -->
<nav class="l-flex l-flex-alignCenter l-flex-0 t-elevation-large">
<button class="m-actionBarItemHorizontal m-actionBarItemHorizontal-secondary" type="button" (click)="handleClickCancel()">
<svg class="m-actionBarItemHorizontal-x-icon t-icon">
<use [attr.xlink:href]="cancelIcon"></use>
</svg>
<span class="m-actionBarItemHorizontal-x-label">Cancel</span>
<span class="m-actionBarItemHorizontal-x-divider m-divider m-divider-large"></span>
</button>

<app-formfield-submit
[formGroup]="skillForm"
[enabled]="formValid"
[dirty]="formDirty"
[observables]="[skillSaved]"
[mobileView]="true"
(errorsOccurred)="handleFormErrors($event)"
></app-formfield-submit>
<div class="m-quickLinks" aria-labelledby="save-quicklinks">
<h3 class="t-visuallyHidden" id="save-quicklinks">Quick Links</h3>
<a (click)="scrollToTopClicked.emit()">Back to top</a>
</div>
</nav>
</div>
</div>

Expand Down
3 changes: 3 additions & 0 deletions ui/src/app/richskill/form/rich-skill-form.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {HasFormGroup} from "../../core/abstract-form.component"
import {notACopyValidator} from "../../validators/not-a-copy.validator"
import {ApiSkillSummary} from "../ApiSkillSummary"
import {Whitelabelled} from "../../../whitelabel"
import { SvgHelper, SvgIcon } from "src/app/core/SvgHelper"

@Component({
selector: "app-rich-skill-form",
Expand All @@ -50,6 +51,8 @@ export class RichSkillFormComponent extends Whitelabelled implements OnInit, Has
searchingSimilarity?: boolean
similarSkills?: ApiSkillSummary[]

cancelIcon = SvgHelper.path(SvgIcon.CANCEL)

constructor(
private fb: FormBuilder,
private route: ActivatedRoute,
Expand Down