Fix/app performance #444
Open
Fix/app performance #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ii/flutter into fix/app-performance
sizzlesloth
reviewed
Sep 5, 2024
| final weightProvider = context.read<BodyWeightProvider>(); | ||
| final measurementProvider = context.read<MeasurementProvider>(); | ||
| final userProvider = context.read<UserProvider>(); | ||
| // final workoutPlansProvider = context.read<WorkoutPlansProvider>(); |
There was a problem hiding this comment.
Should ideally be removed if now unused.
sizzlesloth
reviewed
Sep 5, 2024
| weightProvider.fetchAndSetEntries(), | ||
| measurementProvider.fetchAndSetAllCategoriesAndEntries(), | ||
| ]); | ||
| // log('Loading plans, weight, measurements and gallery'); |
There was a problem hiding this comment.
Remove commented out code if not going to be used (see prev comment).
sizzlesloth
reviewed
Sep 5, 2024
| await workoutPlansProvider.fetchAndSetWorkoutPlanFull(planId); | ||
| workoutPlansProvider.setCurrentPlan(planId); | ||
| } | ||
| // log('Loading current nutritional plan'); |
There was a problem hiding this comment.
Remove (see prev comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (Proposed Changes)
(Please try to mention in bullet points.)
Link to the issue :
(Add link of the issue you have proposed changes to)
Tests
Please make sure to add tests when implementing new features.
Checklist
Please check that the PR fulfills all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).