feat: dc frame previews #340
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dalechyn
commented
May 30, 2024
Comment on lines
+191
to
+213
| /** | ||
| * Path of the next frame. | ||
| * | ||
| * @example '/submit' | ||
| */ | ||
| action?: FrameResponse['action'] | ||
| /** | ||
| * HTTP response headers. | ||
| */ | ||
| headers?: FrameResponse['headers'] | ||
| /** | ||
| * An icon ID. | ||
| * | ||
| * @see https://warpcast.notion.site/Spec-Farcaster-Actions-84d5a85d479a43139ea883f6823d8caa | ||
| * @example `'log'` | ||
| */ | ||
| icon?: Octicon | ||
| /** | ||
| * Title of the frame (added as `og:title`). | ||
| * | ||
| * @example 'Hello Frog' | ||
| */ | ||
| title?: FrameResponse['title'] |
There was a problem hiding this comment.
not sure if we can inherit those docs from FrameResponse – without the comment it doesn't seem to pull up.
dalechyn
commented
May 30, 2024
Comment on lines
+214
to
+243
| } & ( | ||
| | { | ||
| /** | ||
| * Preview Image to render for the frame. Can either be a JSX element, or URL. | ||
| * | ||
| * @example | ||
| * <div style={{ fontSize: 60 }}>Hello Frog</div> | ||
| */ | ||
| image?: JSX.Element | ||
| /** | ||
| * Image options. | ||
| * | ||
| * @see https://vercel.com/docs/functions/og-image-generation/og-image-api | ||
| * | ||
| * @example | ||
| * { width: 1200, height: 630 } | ||
| */ | ||
| imageOptions?: Pretty<Omit<ImageOptions, 'fonts'>> | undefined | ||
| } | ||
| | { | ||
| /** | ||
| * Preview Image to render for the frame. Can either be a JSX element, or URL. | ||
| * | ||
| * @example | ||
| * "https://i.ytimg.com/vi/R3UACX5eULI/maxresdefault.jpg" | ||
| */ | ||
| image?: string | ||
| imageOptions?: never | ||
| } | ||
| ) |
There was a problem hiding this comment.
cannot do a Pick<FrameResponse, 'image' | 'imageOptions'> as it breaks discriminated union.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.