Removes .ruby-version#115
Open
philsturgeon wants to merge 1 commit intowestfieldlabs:masterfrom
philsturgeon:remove-ruby-version
Open
Removes .ruby-version#115philsturgeon wants to merge 1 commit intowestfieldlabs:masterfrom philsturgeon:remove-ruby-version
philsturgeon wants to merge 1 commit intowestfieldlabs:masterfrom
philsturgeon:remove-ruby-version
Conversation
Fixes #111
|
Alternatively it looks like it has been tested with ruby 2.5.8 over on this other PR #126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111
I was trying to contribute some stuff and having it force me onto this old version of ruby felt a little funny and out of place. This isn't an application, so maybe the .ruby-version is too opinionated and restrictive.