ported avro c# to .net standard 2.0#4
Open
SidShetye wants to merge 7 commits intowelly87:masterfrom
SidShetye:netcore2
Open
ported avro c# to .net standard 2.0#4SidShetye wants to merge 7 commits intowelly87:masterfrom SidShetye:netcore2
SidShetye wants to merge 7 commits intowelly87:masterfrom
SidShetye:netcore2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have ported to .net standard 2.0 (somewhat!). There were several changes on the tooling side but some tests fail on all platforms while other only fail on Mac and Linux. I believe these tests failed before too so this doesn't fix those failures themselves - that's probably the next step and as the original author I'm hoping you're able to step in :)
You can simply run the test by
dotnet test. On non-windows platforms you'll get this outputPS: In my repo, it's on the
netcore2branch but unsure about pull requests across branches