Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ghc 9.12 #339

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support ghc 9.12 #339

wants to merge 2 commits into from

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Nov 14, 2024

Library itself can be fixed with a Hackage metadata edit.

@erikd
Copy link
Contributor Author

erikd commented Nov 14, 2024

CI failures are due to CI infrastructure issues.

@erikd erikd force-pushed the master branch 2 times, most recently from 7a3213a to 418c775 Compare December 10, 2024 04:51
@erikd
Copy link
Contributor Author

erikd commented Jan 5, 2025

CI infrastructure seems fixed, but still getting a bunch of CI failures unrelated to this PR.

@cho-m cho-m mentioned this pull request Jan 6, 2025
23 tasks
@TristanCacqueray
Copy link
Contributor

Dear maintainers, could you please recheck the CI? This PR is also needed for ghc-9.10

@erikd
Copy link
Contributor Author

erikd commented Jan 8, 2025

CI results are weird. Have just built with both ghc-9.6.6 and ghc-9.10.1 and tests with both compilers passed.

For ghc-9.12.1 the failure in CI should not happen due to the allow-newer stanza in the cabal.project file. 🤷

@Saizan
Copy link
Collaborator

Saizan commented Jan 8, 2025

CI results are weird. Have just built with both ghc-9.6.6 and ghc-9.10.1 and tests with both compilers passed.

For ghc-9.12.1 the failure in CI should not happen due to the allow-newer stanza in the cabal.project file. 🤷

@erikd the CI workflow (generated with haskell-ci) creates a cabal.project from scratch, which doesn't appear to include an allow-newer stanza. I'm not familiar with the setup beyond that though.

@erikd
Copy link
Contributor Author

erikd commented Jan 8, 2025

@Saizan I am familiar with haskell-ci, but not when used like this. However the missing allow-newer should only affect the ghc-9.12 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants