Add independent log parser fixtures and validation (+ fix 2 parser bugs)#66
Open
zhaojiazheng9-art wants to merge 8 commits into
Open
Add independent log parser fixtures and validation (+ fix 2 parser bugs)#66zhaojiazheng9-art wants to merge 8 commits into
zhaojiazheng9-art wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add hand-written log parser fixtures for JSON, text, and nginx formats to eliminate the 40% false-pass rate caused by parser-generated test data. Includes a dedicated validation script and fixes two parser bugs exposed by the new fixtures.
Changes
json_logs.fixture— 7 JSON log entries with standard and alternative key formatstext_logs.fixture— 6 plain text log entries with timestamps and [bracket] servicesnginx_logs.fixture— 6 Nginx combined-format access log entriesextract_service(): regex[\w+]→[\w-]+to handle hyphenated service namesNginxLogParser: remote_user now reads group 3 instead of group 2 (was reading ident field)Testing