Add independent log parser fixtures#61
Open
glm-5-2 wants to merge 1 commit into
Open
Conversation
- Hand-written JSON, text, and nginx log fixtures (NOT generated by parser) - Tests cover: standard formats, alternative keys, edge cases, invalid input - JSON: 5 tests (standard, Elasticsearch, alt keys, invalid JSON, all valid) - Text: 4 tests (standard, empty line, all non-empty, raw preservation) - Nginx: 6 tests (GET, POST, 429, 304, all valid, invalid line) - Fixes false-pass issue where test data was generated by parser code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounty: $25 — Independent log parser fixtures
Issue
#5
What this does
Adds independent parser fixtures based on hand-written representative log lines, covering the main parser paths without relying on parser-generated test data.
Files
tests/fixtures/json_logs.txt— 4 hand-written JSON log lines + 1 invalidtests/fixtures/text_logs.txt— 4 hand-written text log lines + 1 emptytests/fixtures/nginx_logs.txt— 4 hand-written nginx access log linestests/test_log_parser_fixtures.py— 15 tests across all 3 parsersTests
Why these are independent
The fixtures are hand-written to represent real-world log formats — NOT generated by the parser code itself. This eliminates the 40% false-pass rate mentioned in the issue.