[#1] Add cross-platform fallbacks for memory and load checks#55
Open
lushan888 wants to merge 1 commit into
Open
[#1] Add cross-platform fallbacks for memory and load checks#55lushan888 wants to merge 1 commit into
lushan888 wants to merge 1 commit into
Conversation
- check_memory_usage(): keep /proc/meminfo path on Linux, add psutil fallback, then os.sysconf as final fallback - check_load_average(): keep /proc/loadavg where available, add os.getloadavg() fallback for non-Linux Unix-like systems - Add test_health_check.py with 5 tests: memory fallback without /proc, psutil verification, /proc path, load fallback without /proc, /proc path - All tests pass on macOS (non-Linux) with fallback active - JSON and text output remain backward compatible Issue: weilixiong#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add cross-platform fallbacks for
check_memory_usage()andcheck_load_average()so non-Linux environments (macOS, BSD) report useful values instead of generic/procread failures.Changes
check_memory_usage(): keeps/proc/meminfopath on Linux, falls back to psutil, then os.sysconfcheck_load_average(): keeps/proc/loadavgpath where available, falls back toos.getloadavg()Testing
/proc/meminfo→ psutil → os.sysconf → WARNING/proc/loadavg→os.getloadavg()→ WARNINGChecklist
Closes #1