Fix cross-platform health check crashes on macOS/Windows#49
Open
scotia1973-bot wants to merge 1 commit into
Open
Fix cross-platform health check crashes on macOS/Windows#49scotia1973-bot wants to merge 1 commit into
scotia1973-bot wants to merge 1 commit into
Conversation
Replace Linux-only /proc/meminfo and /proc/loadavg with: - Memory: /proc/meminfo parsing with macOS sysctl/vm_stat fallback and psutil fallback - Load: /proc/loadavg replaced with os.getloadavg() (works on Linux and macOS), with OSError catch for Windows - Disk: os.statvfs kept with shutil.disk_usage() fallback for Windows Closes weilixiong#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The health check tool reads Linux-only
/proc/meminfoand/proc/loadavgdirectly. On macOS or Windows these files do not exist, causing crashes.Changes
Memory check (
check_memory_usage)_read_meminfo_linux()helper_read_mem_macos()fallback using sysctl + vm_stat for macOSLoad average check (
check_load_average)/proc/loadavgwithos.getloadavg()(works on both Linux and macOS)OSErrorcatch for WindowsDisk check (
check_disk_usage)os.statvfs()for Linux/macOSAttributeErrorcatch withshutil.disk_usage()fallback for WindowsCloses #1