Add cross-platform health check fallbacks#48
Open
bingmokaka wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds cross-platform fallbacks for the health check memory and load probes so non-Linux environments can report useful diagnostics when
/procis unavailable.Changes
/proc/meminfoand/proc/loadavgpaths intact.ctypesandGlobalMemoryStatusEx.os.sysconfwhere available.os.getloadavg()where available.unittestcoverage that simulates missing/procfiles and verifies fallback behavior.Testing
python -m unittest tests.test_health_check_fallbacks -vpasses: 5 tests.python tools/health_check.py --json --service backendpreserves JSON output shape; memory reports a meaningful Windows value.PYTHONIOENCODING=utf-8 python tools/health_check.py --service backendpreserves text output shape; memory reports a meaningful Windows value.python build.pywas attempted but the Windows environment lacks the full multi-language toolchain andnpm, so the all-module build crashes when spawningnpm installfor frontend.python build.py -m backendwas also attempted; it reached diagnostic finalization but failed because the bundledencryptlydiagnostic pack step returned an error in this Windows environment. No new diagnostic artifact was committed.Checklist
Closes #1