Add independent log parser fixtures#45
Open
victordb9997 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds independent hand-written parser fixtures for JSON, plain text, and nginx-style logs so parser coverage no longer relies on parser-generated samples.
Fixes #5.
Changes
remote_userextraction to use the third access-log field.subprocess.run()inbuild.pyso Windows.cmdtools such asnpm.cmdcan be launched during validation.Testing
python -m unittest tests.test_log_aggregator_fixtures -vpasses.PYTHONIOENCODING=utf-8 python build.pywas attempted locally. The build script now reaches the module build summary, but this Windows machine is missing several project toolchains (cargo,go,gcc,cmake,make,javac,ruby,luac,ghc) and the bundled diagnostic pack step failed after the summary, so I could not generate a newdiagnostic/build-*.logdartifact here.Checklist