Skip to content

Commit

Permalink
package: use npm ci, remove npm dedupe
Browse files Browse the repository at this point in the history
`npm ci` does not modify the package-lock.json file, which is exactly what we want during packaging time. Otherwise, on Windows, npm will attempt to remove the mac-only dependencies like appdmg from package-lock.json.
  • Loading branch information
feross committed Sep 6, 2019
1 parent 744e720 commit 2834cca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bin/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ const argv = minimist(process.argv.slice(2), {
function build () {
console.log('Reinstalling node_modules...')
rimraf.sync(NODE_MODULES_PATH)
cp.execSync('npm install', { stdio: 'inherit' })
cp.execSync('npm dedupe', { stdio: 'inherit' })
cp.execSync('npm ci', { stdio: 'inherit' })

console.log('Nuking dist/ and build/...')
rimraf.sync(DIST_PATH)
Expand Down

0 comments on commit 2834cca

Please sign in to comment.