Skip to content

Conversation

@Jannih
Copy link

@Jannih Jannih commented Nov 23, 2025

Description

Steps for reproduction

  1. Open the style panel color picker.
  2. Enter colors in various formats: hsl(200 50% 40% / 0.6), oklch(0.7 0.12 45), lab(54% -12 32), #00220011.
  3. Toggle formats via the switcher and verify the color stays consistent and is rendered correctly.
  4. Enter an invalid string (e.g., not-a-color) and observe validation feedback.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what") — not added (code is straightforward)

Before merging

  • tested locally (dev build) — works as expected
  • tested on preview environment (preview dev login: 0000)
  • updated test cases document
  • added/updated tests (css-data parse tests, css-engine to-value test)
  • [n/a] if any new env variables are added, added them to .env file (none)

support colors
@github-actions
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Enable HSL/OKLCH/Lab formats across color parsing and UI". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - style
 - refactor
 - perf
 - test
 - build
 - ci
 - chore
 - revert
 - experimental
Release types
  • feat - A new feature
  • fix - A bug fix
  • docs - Documentation only changes
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor - A code change that neither fixes a bug nor adds a feature
  • perf - A code change that improves performance
  • test - Adding missing tests or correcting existing tests
  • build - Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore - Other changes that don't modify src or test files
  • revert - Reverts a previous commit
  • experimental - Flagged feature

@TrySound
Copy link
Member

Hey, thanks for this. Though I am working on the same feature right now

@Jannih
Copy link
Author

Jannih commented Nov 24, 2025

Hey! Perfect @TrySound ! So should i finish this or do you want to merge it with yours?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants