Skip to content

fix: allow case sensitive path in redirects ( old path field ) #5079 #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025

Conversation

Blazing-Mike
Copy link
Contributor

fixes #5079

Description

this fix was to allow case sensitive path in redirects (specifically the "old-path" field), for users migrating from legacy system this could be important.

Screen Shot 2025-04-03 at 2 00 54 PM

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click on project setting
  2. go to redirects tab
  3. input a path with uppercase letter(s) in the old-path field and the page you want to redirect to
  4. This should work without any error

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@Blazing-Mike Blazing-Mike changed the title fix case sensitive path in redirects ( old path field ) #5079 fix : allow case sensitive path in redirects ( old path field ) #5079 Apr 3, 2025
@Blazing-Mike Blazing-Mike changed the title fix : allow case sensitive path in redirects ( old path field ) #5079 fix: allow case sensitive path in redirects ( old path field ) #5079 Apr 3, 2025
@kof kof requested a review from TrySound June 2, 2025 08:05
@kof
Copy link
Member

kof commented Jun 2, 2025

This was completely forgotten

@Blazing-Mike
Copy link
Contributor Author

i am gonna resolve conflicts and open another pr

@TrySound TrySound merged commit b30e0e3 into webstudio-is:main Jun 27, 2025
9 of 11 checks passed
@TrySound
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow case sensitive path in redirects
3 participants