Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support css variables in shadow properties #5032

Merged
merged 1 commit into from
Mar 25, 2025
Merged

feat: support css variables in shadow properties #5032

merged 1 commit into from
Mar 25, 2025

Conversation

TrySound
Copy link
Member

Closes #4939

Added css variables support with autocomplete in text-shadow and box-shadow properties.

Extended our ast with new "shadow" value to properly represent variables in shadow properties. Though parser still cannot extract variables from value with variables and falls back to "unparsed" value.

Screenshot 2025-03-23 at 00 45 03

Added css variables support with autocomplete in text-shadow and
box-shadow properties.

Extended our ast with new "shadow" value to properly represent variables
in shadow poperties.
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed that we separately fix editing code area with variables: when it happens we replace fields with computed values as soon as user tries to edit the shadow with variables inside

@TrySound TrySound merged commit 11bb528 into main Mar 25, 2025
17 checks passed
@TrySound TrySound deleted the shadow branch March 25, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box shadow and text shadow variables don't save
2 participants