[DOCS] webpack documentation concept and config section from CommonJS to ESM #7731
+645
−644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@payelcs2024ipcw-source is attempting to deploy a commit to the OpenJS Foundation Team on Vercel. A member of the Team first needs to authorize it. |
evenstensberg
requested changes
Dec 23, 2025
Member
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
Thanks for your PR! I left a few comments that needs to be adressed. ☀️
| entry: './foo.js', | ||
| output: { | ||
| path: path.resolve(__dirname, 'dist'), | ||
| path: path.resolve(process.cwd(), 'dist'), |
Member
There was a problem hiding this comment.
Dont use process.cwd, use this
src/content/concepts/index.mdx
Outdated
| entry: './path/to/my/entry/file.js', | ||
| output: { | ||
| path: path.resolve(__dirname, 'dist'), | ||
| path: path.resolve(process.cwd(), 'dist'), |
src/content/concepts/plugins.mdx
Outdated
| new webpack.ProgressPlugin().apply(compiler); | ||
|
|
||
| compiler.run(function (err, stats) { | ||
| compiler.run((err, stats) { |
Member
There was a problem hiding this comment.
keep the function syntax its easier to learn and read
There was a problem hiding this comment.
Sure, I'll keep it easy to read. Thank you reviewing
Author
|
Completed the assigned edits in the concept section and proceeded with further improvements in the config section. |
payelcs2024ipcw-source
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7636
This pull request updates the Concepts and Config section of the webpack documentation to reflect the transition from CommonJS to ECMAScript Modules (ESM).
Changes made:
module.exportsexamples withexport default.require(...)usage toimport ... from .....import.meta.urlfor resolving paths instead of__dirname).