test: enable offline test by renaming file to correct pattern #7696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offline test file was named 'offline._cy.js' which doesn't match Cypress's test file pattern '*.cy.js', causing the test to be silently skipped. Renamed to 'offline.cy.js' to enable execution. This ensures PWA offline functionality is properly tested in CI/CD.
|
@Rupendra0 is attempting to deploy a commit to the OpenJS Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offline test file was named 'offline._cy.js' which doesn't match Cypress's test file pattern '*.cy.js', causing the test to be silently skipped. Renamed to 'offline.cy.js' to enable execution.
Summary
This PR fixes a critical testing issue where the offline functionality test was being silently skipped due to incorrect file naming.
Problem:
cypress/e2e/offline._cy.js*.cy.js(not._cy.js)Solution:
offline._cy.js→offline.cy.jsImpact:
File changed:
cypress/e2e/offline._cy.js→cypress/e2e/offline.cy.js(renamed)What kind of change does this PR introduce?
Test infrastructure fix - enables a previously disabled/skipped test file by correcting its naming pattern to match Cypress conventions.
Did you add tests for your changes?
No new tests were added. This PR enables an existing test that was already written but not being executed due to the incorrect filename. The test file
offline.cy.jscontains comprehensive offline functionality tests that will now run.Does this PR introduce a breaking change?
No. This PR does not introduce any breaking changes. It's purely a file rename that:
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No additional documentation needed. This is an internal testing infrastructure improvement. The test will now appear in CI/CD test results and coverage reports.
Additional Context:
This issue was discovered during a comprehensive documentation and codebase analysis. All other Cypress E2E test files follow the
*.cy.jsnaming convention:check-server-side-rendering.cy.jscheck-sub-navigation.cy.jsclick-menu-scroll-top.cy.jsclient-side-redirection.cy.jsoffline._cy.js(previously disabled)pr_4435.cy.jsscroll.cy.jssearch.cy.jstoggle-dark-mode.cy.jsThis fix ensures consistency with the project's test naming conventions and enables important offline functionality validation.