Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix header link #4213

Merged
merged 3 commits into from
Nov 29, 2020
Merged

fix header link #4213

merged 3 commits into from
Nov 29, 2020

Conversation

chenxsan
Copy link
Member

The header link was missing when migrating icon fonts to inlined svg in this PR #4192.

image

@vercel
Copy link

vercel bot commented Nov 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/pbpj9desh
✅ Preview: https://webpack-js-org-git-bugfix-fix-icon-link.webpack-docs.now.sh

@chenxsan
Copy link
Member Author

I don't know why Vercel deployment failed again.

@chenxsan chenxsan closed this Nov 28, 2020
@chenxsan chenxsan reopened this Nov 28, 2020
@chenxsan chenxsan marked this pull request as ready for review November 28, 2020 08:12
@chenxsan chenxsan merged commit f913b23 into webpack:master Nov 29, 2020
@chenxsan chenxsan deleted the bugfix/fix-icon-link branch November 29, 2020 01:51
@montogeek montogeek added the UI/UX label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants