-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
docs(plugins) Add mini-css-extract-plugin #2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -59,16 +61,19 @@ __webpack.config.js__ | |||
+ { | |||
+ test: /\.css$/, | |||
+ use: [ | |||
+ 'style-loader', | |||
+ MiniCssExtractPlugin.loader, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work with hot reloading, at least not yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you suggest we add a note that hot reloading wont work for now with MiniCssExtractPlugin or is there a known workaround? @Kovensky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The known workaround is to use style-loader
when hot reloading is enabled 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, so we probably can skip updating this guide for now (asset-management) and leave it with style-loader
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides this, the changes look good to me if they were properly tested.
Is it necessary to add some warning box on other plugin page to let the developer know that this one should be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a redirect from deleted
plugin is added for that, also the text of the page says why it came to replace ETWP: https://github.com/webpack-contrib/mini-css-extract-plugin
Otherwise works fine locally.
@Kovensky am i right we dont need to update asset-management guide for now?
475d01d
to
d119b6e
Compare
ok cleaned up |
Reading through #1854 we shouldnt remove redundant plugins pages but add a deprecation warning to their pages (this means pull requests into readme.md of respective plugins repos). Should i probably remove the redirect and plugin fetch removal from this PR then? CC @montogeek |
I just spotted the redirect @EugeneHlushko, yes, we don't delete or do that for deprecated plugins, we just add a deprecation warning similar to the one in here https://webpack.js.org/plugins/commons-chunk-plugin/ Consider teams that are not ready to upgrade and need this documentation for their use case. I think that with that change this would be good to go. |
@jeremenichelli done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments Eugene 👍
Thanks |
fixes #2016