Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide): The CLI moved into a separate package: webpack-cli #1877

Closed
wants to merge 1 commit into from
Closed

docs(guide): The CLI moved into a separate package: webpack-cli #1877

wants to merge 1 commit into from

Conversation

kumarbhot
Copy link

Executing webpack is now possible with webpack-cli instead of just webpack. Added that to npm installation step as well as the final execution instruction. A little unsure about how to add mention to the --mode flag.

@jsf-clabot
Copy link

jsf-clabot commented Mar 3, 2018

CLA assistant check
All committers have signed the CLA.

@skipjack
Copy link
Collaborator

skipjack commented Mar 3, 2018

@jeremenichelli maybe this should be re-targeted at next if you're going to merge soon?

Always displaying the latest version number in the badge in the sidebar has definitely caused some confusion (e.g. #1854). We should start tagging the repo and versioning the package.json with the currently documented version using something like standard-version. This would allow us to easily identify where documentation for each version lies. Related to #1856 and my comment there as well.

cc @jeremenichelli @montogeek @TheDutchCoder

@TheDutchCoder
Copy link
Collaborator

Hi @kumarbhot thanks for your contribution!

We're actually in the process of updating the docs for v4 and this particular change was already merged into the next branch: 650f69e

We're also planning on making versioned docs.

@kumarbhot kumarbhot deleted the patch-1 branch March 4, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants