Skip to content

fix(scripts): add missing target flag for llms-txt generator - #261

Open
sameerchore wants to merge 1 commit into
webpack:mainfrom
sameerchore:fix/html-script
Open

fix(scripts): add missing target flag for llms-txt generator#261
sameerchore wants to merge 1 commit into
webpack:mainfrom
sameerchore:fix/html-script

Conversation

@sameerchore

@sameerchore sameerchore commented Sep 4, 2026

Copy link
Copy Markdown

Summary

In scripts/html/index.mjs, the web, orama-db, and sitemap targets use the -t flag explicitly.

llms-txt was missing its own -t flag. This change adds it for consistency:

'-t', 'sitemap', '-t', 'llms-txt',

The CLI was handling llms-txt correctly, But by this change it just makes the arguments consistent and easier to maintain for future target additions .

What kind of change does this PR introduce?

  • Fix / Code cleanup
  • Makes the CLI target arguments consistent

Did you add tests for your changes?

No new tests were added because this is a small CLI argument formatting change.

The following checks were run successfully:

  • npm run lint
  • npm run format:check
  • npm test
  • coderabbit review --agent — 0 findings

Does this PR introduce a breaking change?

No.

Documentation

No documentation changes are needed because this is an internal build script change.

Use of AI

AI was used to understand behaviour of inconsistent flag in scripts/html/index.mjs only.

Summary by CodeRabbit

  • New Features
    • Documentation generation now supports the orama-db target.

@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
webpack-doc-kit Ready Ready Preview Sep 5, 2026 10:57am UTC

Request Review

@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 4, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: sameerchore / name: Sameer Chore (91ef123)

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f89a4d1e-da92-49cb-933f-345f88df2ece

📥 Commits

Reviewing files that changed from the base of the PR and between 2cf37ed and 91ef123.

📒 Files selected for processing (1)
  • scripts/html/index.mjs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The runDocKit helper now passes the orama-db target to @doc-kit/cli generate. The command continues to generate the existing web and sitemap targets.

Merge Risk: ⚪ Minimal · up to b646b

The HTML documentation build now also generates the Orama database target alongside existing outputs. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding the missing target flag for the generator in scripts/html/index.mjs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@moshams272

Copy link
Copy Markdown
Member

could you rebase :)

Signed-off-by: Sameer Chore <sameerchore5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants