Skip to content

fix: "Overlay enabled" false positive #5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

henryqdineen
Copy link
Contributor

When client.overlay is set to false the resource query string will be contain overlay=false (relevant code). This PR fixes the enabledFeatures logic to handle cases when overlay=false

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

Fixes misleading console logs

Breaking Changes

No

Additional Info

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.38%. Comparing base (af6bd68) to head (ca13b9e).
Report is 124 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5464      +/-   ##
==========================================
- Coverage   90.29%   83.38%   -6.92%     
==========================================
  Files          15       13       -2     
  Lines        1577     2028     +451     
  Branches      601      745     +144     
==========================================
+ Hits         1424     1691     +267     
- Misses        140      303     +163     
- Partials       13       34      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait
Copy link
Member

@henryqdineen Can we fix linting?

@ovflowd
Copy link
Member

ovflowd commented Apr 29, 2025

@alexander-akait, it seems like a GHSA was released. Can we open a PR with npm audit --fix, seems like 2.0.9 is patched and we're on 2.0.7

@alexander-akait
Copy link
Member

@ovflowd oh, I see, I will resolve it before the next release, so let's merge it

@alexander-akait alexander-akait merged commit 18e72ee into webpack:master Apr 29, 2025
40 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants