Skip to content

Add option historyApiFallback #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Add option historyApiFallback #922

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
209526e
Add option historyApiFallback
drudrum May 30, 2021
59382db
Update README.md
drudrum Jun 1, 2021
8825e2e
Tests
drudrum Jun 1, 2021
12a1e19
Merge branch 'webpack:master' into master
drudrum Jun 2, 2021
51e500a
Merge branch 'master' into master
drudrum Dec 29, 2022
dda8999
chore: fix missing 2 ts
drudrum Dec 29, 2022
4ed02bb
chore: ts at comments
drudrum Dec 29, 2022
c3242ae
chore: after build
drudrum Dec 29, 2022
baa8925
Merge branch 'master' into master
alexander-akait Jan 13, 2023
e47ffe6
chore: run build cmd
drudrum Mar 9, 2023
df8d94d
Merge branch 'master' into master
drudrum Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,14 @@
}
]
},
"historyApiFallback": {
"description": "When using the HTML5 History API, the index.html page will likely have to be served in place of any 404 responses. Enable historyApiFallback by setting it to true",
"anyOf": [
{
"type": "boolean"
}
]
},
"stats": {
"description": "Stats options object or preset name.",
"anyOf": [
Expand Down
5 changes: 4 additions & 1 deletion src/utils/getFilenameFromUrl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,11 @@ export default function getFilenameFromUrl(context, url) {
filename = path.join(outputPath, querystring.unescape(pathname));
}

let fsStats;
if (!context.outputFileSystem.existsSync(filename) && options.historyApiFallback){
filename = path.join(outputPath);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need path.join here, it doesn't have sense

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check. Look like mistake. May be we need change it to path.resolve

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this code looks like this option is not necessarily at all.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything should work without this option.
I am confused.
I feel that i need cancel this PR.

}

let fsStats;
try {
fsStats = context.outputFileSystem.statSync(filename);
} catch (_ignoreError) {
Expand Down