Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Render Selected Module Size Total #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vwb
Copy link

@vwb vwb commented Apr 29, 2020

Small UI update to render a label of the total selected module size in the sidebar. If the user has all the modules selected, or only one, it will not display as that information is easily accessible.

Image 4-28-20 at 6 31 PM

Have found myself needing this more often than not to compare the sizes of subsets of bundles.

Wasn't able to find any tests on UI components. If I'm simply blind, please point me in the right direction and I'm happy to add some coverage.

Thanks!

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@vwb
Copy link
Author

vwb commented Aug 7, 2020

Something seems to have gone wrong with the license bot, I completed the check months ago but still is saying pending.

If there anything I can do on my side to address this let me know.

@valscion valscion closed this Aug 10, 2020
@valscion valscion reopened this Aug 10, 2020
@valscion
Copy link
Member

I think I triggered a new CLA check with close+reopen. It looks like the commit in this PR is associated with https://github.com/vincent3 GitHub user account, and that user account might not have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants