-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB Elements - Data Loaders #4424
Open
adrians5j
wants to merge
40
commits into
dev
Choose a base branch
from
adrian/pb-loaders
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces the
useLoader
React hook, which makes it easier to load data within page elements. For example, the existing SpaceX page element example can be now rewritten in the following way.Before:
After (with the
useLoader
hook):Why is this important?
From the above example, we can see that, with the
useLoader
React hook, our code looks a bit cleaner.Nice to have, but still, this is not the main reason we're introducing this feature.
The main reason we're introducing this feature is data caching which improves page performance and user experience.
What
useLoader
does behind the scenes is it enables caching of the data that has been returned from the provided data fetcher function (in the above example, the function that's pinging the SpaceX API).This caching is happening during page prerendering. Once the data has been returned, it's basically injected into the body of the page. For example:
With the data being injected into the page and also included in the final page prerendering snapshot, it can then be accessed during an actual page visit. Once the page is visited, upon rendering the page element, the
useLoader
will first check if the data is already in the page HTML. If so, it'll use it and no remote API calls will be issued. Meaning immediate content in the page element, which means better page performance and better UX.Extra Changes
AddButtonLinkComponent
decorator removedHow Has This Been Tested?
A Jest test for parsing data cached in HTML during the prerendering process.
Manual testing on the frontend side.
Documentation
Changelog. Update existing docs.