feat: Input component#1
Merged
webfansplz merged 1 commit intowebfansplz:feat-inputfrom Nov 14, 2022
Merged
Conversation
Owner
|
It’s so cool. I love it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@webfansplz I think it would be even more powerful if we went this way: having an input that can be focused and looks more like a real ui input that can be changed at any time. It's not a finished input and could be simplified to only the text without the label but let me know if this doesn't make my comments on vue-terminal#15 and vue-terminal#18 clearer.
You can test it with
pnpm run play:devScreenFlow.mp4