Skip to content

Commit

Permalink
Use old namespace reconciliation behaviour in PHP > 8.1.24 (#8)
Browse files Browse the repository at this point in the history
In PHP 8.1.25, the old namespace reconciliation behaviour was restored,
see https://www.php.net/ChangeLog-8.php#PHP_8_1. Thus, we have to limit
our workaround to versions between 8.1.21 and 8.1.24.
  • Loading branch information
sebastiankugler authored Oct 28, 2023
1 parent d760f5b commit de3cc3a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Webfactory/Dom/HTMLParsingHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ protected function defineImplicitNamespaces(): array
* but it perfectly matches our observation that changing the namespace order fixes several bugs and tests
* in various private projects of ours.
*/
if (phpversion('xml') >= '8.1.21') {
if ((phpversion('xml') >= '8.1.21') && (phpversion('xml') < '8.1.25')){
return [
'html' => 'http://www.w3.org/1999/xhtml', // für XPath
'' => 'http://www.w3.org/1999/xhtml', // default ns
Expand Down

0 comments on commit de3cc3a

Please sign in to comment.