Fix for issues_657 and issue_983

[P-Courteille]

Hello

📝 Description

Attempt to fix:

• issue 657
• issue 983

---

💡 Explanation

In the previous version of the code, the OCR function was added first to each instance of the browser and then to the browser object.

The problem is, @wdio\utils\build\index.js (line 388) already add the command to each instance so the commande added to each instance was overwritten by the one containing the loop of each instance.

→ Resulting in the issue 983

This issue was also the reason of the loop from issue 657, because each instance called the multi remote version of the command when we use:
browserInstance[commandName].apply(browserInstance, args)

✏️ Modifications

1. Tried to update the type to be compatible with the change done in this webdriverio commit, without this change, the build was not possible.

→ I'm not really confident about this part

2. Change the addCommand order for Multi Remote

   • first, add the command to Browser in a Multi Remote version (with a loop to do the function in each instance)
   • then, add the command to each instance in a Single Remote version
     In both ocr-service and visual-service

3. Inside the package.json of visual reporter:
   "clean": "rimraf coverage build *.tsbuildinfo"
   is replaced by:
   "clean": "rimraf coverage build --glob *.tsbuildinfo"
   Because without that, it will fail on Windows in pathArg check :

    if (platform === 'win32') {
        const badWinChars = /[*|"<>?:]/;
        const { root } = parse(path);
        if (badWinChars.test(path.substring(root.length))) {
            throw Object.assign(new Error('Illegal characters in path.'), {
                path,
                code: 'EINVAL',
            });
        }
    }

⚠️ Warnings

I'm not a javascript/typescript expert so maybe:

• it's overkill,
• some changes are useless,
• some changes are perfectible,
• some changes doesn't follow good practice

But at least it work with both calls from Browser or MultiRemoteBrowser and no longer loop.

---

Best regard,
Paul

[changeset-bot]

🦋 Changeset detected

Latest commit: 9fe32a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@wdio/ocr-service	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: P-Courteille (9fe32a8)

[wswebcreation]

Hi @P-Courteille

Thanks for this PR. I'm currently in the middle of a large refactor that would "simplify" a lot for the Visual package. See also #982. I want to release this in the coming days.

Can you do me a favor? First of all split all adjustments into "smaller" PR's that are connected to each service separately. So we can release them as separate fixes?

It would be great if you can create a PR for the Visual Service based on #982 (I know, a big ass one). But then we can release it as one fix.

Thanks again!

[P-Courteille]

Hi @P-Courteille

Thanks for this PR. I'm currently in the middle of a large refactor that would "simplify" a lot for the Visual package. See also #982. I want to release this in the coming days.

Can you do me a favor? First of all split all adjustments into "smaller" PR's that are connected to each service separately. So we can release them as separate fixes?

It would be great if you can create a PR for the Visual Service based on #982 (I know, a big ass one). But then we can release it as one fix.

Thanks again!

Hi @wswebcreation,

I'm not sure I've correctly understood what you expect from me (especially for the base branch of fixes for other packages than visual-service), so if I miss the point, don't hesitate to let me know.

I retrieved your PR 982, ws/rewrite-core and then:

• Created PR 991 using ws/rewrite-core as base to fix issue 990 for visual-reporter
• Created PR 992 using ws/rewrite-core as base to fix issue 657 for ocr-service
• Created PR 993 using ws/rewrite-core as base to fix issue 983 for visual-service

I didn't tried this time to update the type of executor/ExecuteScript to be compatible with the change done in this webdriverio commit because it was related to webdriver-image-comparison and since you switch to image-comparison-core, it's no longer a subject at this level.

Best regards,
Paul