Fixes #3688 - Freeze Werkzeug version #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @karlcow |
karlcow
approved these changes
Apr 4, 2022
ksy36
added
status: add to changelog
type: dependencies
and removed
status: add to changelog
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some failing tests in CircleCI and I want to freeze Werkzeug version to 2.0.1 to fix them.
As we're not pinning Werkzeug version in requirements.txt, the most recent one is installed in CircleCI (2.1.0). In version 2.1.0, werkzeug has removed the as_tuple argument in the test client. Our current version of Flask is 2.0.1 still passes it, therefore the error is thrown. So freezing Werkzeug to 2.0.1 will address this.
https://flask.palletsprojects.com/en/2.1.x/changes/#version-2-1-0
The test client’s as_tuple parameter is removed. Use response.request.environ instead.There is a separate issue for upgrading Flask to 2.1.1 (#3687), which requires additional testing as there are some failing tests. I want to deploy #3686 first, before updating Flask, in case something breaks :)