test(ci): verify ffi-backend tests + example link on macOS (#119)#221
Merged
Conversation
PR #117 fixed build.rs to link libc++ (not libstdc++) on Apple targets, but its dual-mode CI step was scoped to --lib, so the integration tests and the generate_patt example were never re-built on macOS after the fix. This left open whether the libc++ fix was sufficient or whether a separate macOS linker issue remained. Add a macOS-gated step to the kpm-build matrix that builds the ffi-backend integration tests (--no-run) and the generate_patt example, confirming they link against libc++. Use --no-run because executing the pose-sensitive assertions cross-platform is out of scope — that float-drift question is tracked in #118, which keeps test_full_pipeline_pose gated to Linux. Refs #119 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kalwalt
added this to the
v0.8.0 — Pure-Rust completeness, validation & polish milestone
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a macOS-gated step to the
kpm-buildmatrix that builds theffi-backend integration tests (
--no-run) and thegenerate_pattexample, confirming they link on Apple targets.
PR #117 fixed
build.rsto linklibc++(notlibstdc++) on Appletargets after the macOS runner produced
ld: library 'stdc++' not foundwhen building
tests/nft_pipelineand thegenerate_pattexample. But#117's dual-mode CI step was scoped to
--lib, so the integration testsand examples were never re-built on macOS after the fix — leaving open
whether the libc++ change was sufficient (#119).
This step closes that gap: if the macOS leg goes green, the libc++ fix is
confirmed and #119 can be closed as resolved by #117. If it fails with a
different error, we have a reproducible signal to root-cause.
--no-runis deliberate. This verifies linkage only; actually executingthe pose-sensitive assertions cross-platform is out of scope — that
float-drift question is tracked in #118, which keeps
test_full_pipeline_posegated to Linux. (The library itself already builds with
--features ffi-backendon macOS via the existingBuild kpm backendstep; the gapwas specifically the test + example targets.)
Verification happens in CI itself: the macOS leg of this PR's
kpm-buildmatrix exercises the new step.
Refs #119
🤖 Generated with Claude Code