Add Certificate Authority Generating tool to Crux#32
Open
Puneetha17 wants to merge 6 commits intoweb3labs:masterfrom
Open
Add Certificate Authority Generating tool to Crux#32Puneetha17 wants to merge 6 commits intoweb3labs:masterfrom
Puneetha17 wants to merge 6 commits intoweb3labs:masterfrom
Conversation
conor10
reviewed
Aug 24, 2018
Member
conor10
left a comment
conor10
left a comment
There was a problem hiding this comment.
Looks good - I'm interested to get your responses to my comments. The README will also need to be updated.
| BasicConstraintsValid: true, | ||
| } | ||
|
|
||
| privateKey, err := rsa.GenerateKey(rand.Reader, 2048) |
Member
There was a problem hiding this comment.
What flexibility is there for supporting other key types?
| config.CertGetInt(config.ValidityYears), | ||
| config.CertGetInt(config.ValidityMonths), | ||
| config.CertGetInt(config.ValidityDays)), | ||
| IsCA: config.CertGetBool(config.IsCA), |
Member
There was a problem hiding this comment.
If it's not a certificate authority, could we do signing on behalf of a local authority who's keys are on the same host? I appreciate this isn't exactly a production use case, but could be good to explore
| import ( | ||
| "crypto/rand" | ||
| "crypto/rsa" | ||
| "crypto/x509" |
Member
There was a problem hiding this comment.
It's cool that this is part of the standard library. We may want to split it out into a separate project or binary called crux-utils or similar. But I'd be interested to get your views.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.